Unbox slot types #13382
Merged
Unbox slot types #13382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbox the types
Global_slot_since_genesis.t,Global_slot_since_hard_fork.t, andGlobal_slot_span.t. Those types have a single constructor, so the variant tag conveys no information, hence the run-time representation of the type can be the same as the constructor argument. This change saves some space, because the type tag is elided, and some time, boxing and unboxing values is not needed.For generality,
ppx_versionis changed so that if a type is unboxed, a generatedWith_top_tagorWith_version_tagsmodule will also have an unboxed type. That part of this PR was tested when the slot types had such modules, though they do not now.