Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphql polling log engine berk #13384

Merged
merged 50 commits into from
Jun 15, 2023
Merged

Graphql polling log engine berk #13384

merged 50 commits into from
Jun 15, 2023

Conversation

QuiteStochastic
Copy link
Contributor

psteckler and others added 30 commits June 7, 2023 11:42
@psteckler
Merge pull request #13347 from MinaProtocol/feature/rm-token-snapp-fe…
757ec9f 
…atures
writing the log engine, stubbing out the actual graphql querry
4aab880
@mrmr1993
Add stub GraphQL endpoints for polling from Lucy
7ece45f
@mrmr1993
WIP ran out of time
4db19d9
@mrmr1993
Store log messages for integration test executive in Mina_lib
c6d9066
@mrmr1993
Filter by structured_event_id
ceb896d
well it compiles
00f35e9
check if start filtered log is ok
eed4a7e
switch out the log engine
130b3e4
fix mistake with reversed if statement
63436bb
add debuging logs
6cc55d2
iter in parallel
75cc118
insert an after statement
8951656
downgrade the annoying log message
150b9d2
let it fail safely if it fails during poll_start_filtered_log
6faba51
@mrmr1993
Silence logs from GraphQL polling
3ffd42a
@mrmr1993
Poll each node in its own loop for structured logs, reformat the filter
4b6e848
@mrmr1993
Doc strings, why not
3409831
@mrmr1993
Update parsing
8ceb4f9
@mrmr1993
Remove unused network parameters
287982f
@mrmr1993
Pause between filtered log entry poll events
0d2a9b2
@mrmr1993
Remove some noisy debugging logs
8718247
@mrmr1993
Use arrays, we only ever iterate and take the length anyway
e0a2452
@mrmr1993
Remove noisy log
fc0da2a
@mrmr1993
There's no good reason to wait for the GraphQL to return, so don't
445164a
@mrmr1993
Reduce delay in GraphQL filtered log request retries
c77e296
@mrmr1993
DO NOT MERGE: Include debug logs in output
dce4682
@mrmr1993
Handle nodes going offline
f23c4b4
@mrmr1993
Emit the Node_offline event if we fail to poll or events aren't setup
6970ebe
try to hook up the archive node to graphql
901cece
@QuiteStochastic QuiteStochastic requested review from a team as code owners June 11, 2023 21:15
@QuiteStochastic QuiteStochastic changed the base branch from develop to berkeley June 11, 2023 21:16
mrmr1993
mrmr1993 reviewed Jun 11, 2023
View reviewed changes
src/lib/logger/logger.mli Outdated Show resolved Hide resolved
src/lib/logger/logger.mli Outdated Show resolved Hide resolved
src/lib/logger/native/logger.ml Outdated Show resolved Hide resolved
@mrmr1993
Copy link
Member

!ci-build-me

@QuiteStochastic
Copy link
Contributor Author

!ci-build-me

@QuiteStochastic
Copy link
Contributor Author

!ci-build-me

mitschabaude
mitschabaude approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, fixing the JS build failure should be easy, let me know if you need help!

src/lib/logger/logger.mli Show resolved Hide resolved
@QuiteStochastic
Copy link
Contributor Author

!ci-build-me

@QuiteStochastic
Copy link
Contributor Author

!ci-build-me

@QuiteStochastic
Copy link
Contributor Author

!ci-build-me

@mrmr1993
Copy link
Member

!approve-for-mainnet

@mrmr1993
Copy link
Member

!approved-for-mainnet

@mrmr1993 mrmr1993 merged commit 39faee4 into berkeley Jun 15, 2023
@mrmr1993 mrmr1993 deleted the graphql_polling_log_engine_BERK branch June 15, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuiteStochastic @mrmr1993 @mitschabaude @psteckler