Don't check ledger hash at start; restore final checkpoint #13600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
ghost-not-in-the-shell
approved these changes
Jul 25, 2023
|
The fix for payment test hasn't been merged for compatible. There's some merge conflict hasn't been resolved with the berkeley and develop branch (the test executive module has been changed). Helena is picking up the work this week. My suggestion for now would be just retry the test manually. |
|
!ci-build-me |
This was referenced Jul 25, 2023
dkijania
approved these changes
Jul 26, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After loading the blocks it's going to replay, the replayer builds a table from global slots to ledger and state hashes. If the start slot did not contain a block, it would search backwards and never find the most recent hashes, because only the blocks to be replayed are loaded, no blocks before the start slot. So don't look for the ledger hash at the start slot -- we haven't yet replayed anything. We didn't see this issue until we started using checkpoint files.
Also, restore the checkpoint file dumped at the finish, but only write a checkpoint file if the block at a slot is canonical.
Updated the cron job to use image from this PR.