Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up unit tests in develop #14392

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

mrmr1993
Copy link
Member

This PR tweaks the logic in Proof_cache to handle ignore the new fields added for custom gates/chunking. This allows for the same unit test speed-up as we get in compatible.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 requested a review from a team as a code owner October 19, 2023 11:46
@mrmr1993
Copy link
Member Author

!ci-build-me

Copy link
Contributor

@rbonichon rbonichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrmr1993 mrmr1993 merged commit f16e20a into develop Oct 19, 2023
@mrmr1993 mrmr1993 deleted the feature/use-proof-cache-develop branch October 19, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants