Use the correct values for the fork config #15094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular: * we want to use the best tip's hash * the genesis block already has blockchain length set to the fork's blockchain length, so we're double counting if we manually attempt to do it here. This change makes these so. It works out actually simpler than the code that was written.
|
!ci-build-me |
|
!ci-build-me |
|
The scope of this is now reduced after the merge of #15079. Between the 2 PRs, this fixes
|
emberian
approved these changes
Feb 13, 2024
In particular: * we want to use the best tip's hash * the genesis block already has blockchain length set to the fork's blockchain length, so we're double counting if we manually attempt to do it here. This change makes these so. It works out actually simpler than the code that was written.# Please enter the commit message for your changes. Lines starting
|
This PR now represents the merge-back of #15109. |
|
!ci-build-me |
Remove merges-cleanly job for rampup, now that it is retired
emberian
approved these changes
Feb 14, 2024
|
!approved-for-mainnet |
Fork_config loses previous_ label
|
!ci-build-me |
Problem: compiled parameters are explicitly listed in the fork config exported with the Graphql. This may leas to bugs when using the fork config in laucnhing a fork network. Solution: do not include runtime config into fork config.
|
!ci-build-me |
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
This change makes these so. It works out actually simpler than the code that was written.