[Rosetta] use mina missing block guardian script instead of download missing blocks #16375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-nightly-me |
kaozenn
reviewed
Nov 21, 2024
| @@ -109,7 +116,7 @@ MINA_DAEMON_PID=$! | |||
| sleep 30 | |||
|
|
|||
| echo "========================= POPULATING MISSING BLOCKS ===========================" | |||
| ./download-missing-blocks.sh --network ${MINA_NETWORK} --archive-uri ${PG_CONN} & | |||
| /etc/mina/archive/missing-blocks-guardian.sh single-run & | |||
There was a problem hiding this comment.
Thoughts: The missing-blocks-guardian is not only used once to populate the missing blocks between the daily SQL dump and the current latest available block. The missing-blocks-guardian should run every hour to ensure no blocks are missed in the long run.
There was a problem hiding this comment.
Oki, so we should use different mode of missing-blocks-guardian which will run as daemon
|
!ci-build-me |
|
!ci-nightly-me |
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting fix only from PR: #16346, while waiting for test stabilization
How i tested it: