Optimizing archive node genesis account function #16468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-docker-me |
dkijania
changed the title
|
!ci-docker-me |
dkijania
changed the base branch from
compatible
to
dkijania/apply_caqti_patch
dkijania
changed the title
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizing archive node genesis account function. Function tries to inserts all accounts specified in genesis ledger config file. However, it does it in non optimal way. Namely it open transaction at start then tries to add all accounts and finally commits. This can lead to OutOfMemory issues in postgres process as for instance mainnet genesis ledger contains 200k+ accounts. We experienced that problem on our performance environment. Solution is to make more granular commits during import. New code chop account to be inserted list into 100 account batches (this is measured value as 500 was also making postgres memory increase till 40~gb)