Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic proof_cache_tag #16478

Merged

Conversation

georgeee
Copy link
Member

Add basic proof_cache_tag.
No cache implementation, just "identity".

A step towards Use Proof_cache_tag.t in Ledger_proof.t #16469.

Explain how you tested your changes:

  • It's a refactoring that doesn't change any behavior
  • It compiles :)

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested a review from a team as a code owner January 21, 2025 18:41
@georgeee
Copy link
Member Author

!ci-build-me


type cache_db

val create_db : unit -> cache_db
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a head's up that in my PR which is based on this i wrapped it into (cache_db, [> Initialization_error of Error.t) Async.Deferred.Result.t. is that ok ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely ok, also the first argument will be string in your case, not unit.

@georgeee georgeee merged commit e49b755 into compatible Jan 23, 2025
44 checks passed
@georgeee georgeee deleted the georgeee/proof-cache-tag-2-basic-proof_cache_tag branch January 23, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants