Manually implement JSON array printing to avoid stack overflow #16583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yojson's pretty printing creates a huge call stack using the built-in OCaml list iterators. Since we're only printing an array of objects, we can easily implement a tail-recursive version
2 tasks
|
!ci-build-me |
| Format.fprintf Format.std_formatter "[\n " ; | ||
| let print_comma = ref false in | ||
| List.iter accounts ~f:(fun a -> | ||
| if !print_comma then Format.fprintf Format.std_formatter "\n, " |
There was a problem hiding this comment.
Could you add the comma before \n? That's how it is in the previous version, not sure if that makes any difference
deepthiskumar
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yojson's pretty printing creates a huge call stack using the built-in OCaml list iterators. Since we're only printing an array of objects, we can easily implement a tail-recursive version.
This fixes #16579.