Buildkite auto jobs and check dhall #4823
Conversation
| @@ -0,0 +1,5 @@ | |||
| # Builds all dhall entrypoints | |||
| check: | |||
| dhall <<< './src/Prepare.dhall' | |||
There was a problem hiding this comment.
You should handle the stderr of this to identify which file failed (hint: writing a check-dhall.sh would be helpful here). At minimum, can you pipe the stdout of this to /dev/null?
There was a problem hiding this comment.
Actually I like the feedback in stderr and stdout during the dev loop (anecdotally) even if it succeeds, it's nice to be able to eyeball all the yaml. Is this okay?
There was a problem hiding this comment.
You can leave it for now, but I would still like to see the explicit call out of which file failed like I mentioned. Otherwise you don't know what file failed from the output, do you?
There was a problem hiding this comment.
It short circuits on failure and you see something like this:
The error messages are very clear 👍
.buildkite/Makefile
Outdated
| check: | ||
| dhall <<< './src/Prepare.dhall' | ||
| dhall <<< './src/Monorepo.dhall' | ||
| ls src/jobs | xargs -I{} bash -c 'dhall <<< ./src/jobs/{}/Pipeline.dhall' |
There was a problem hiding this comment.
Suggest: for f in ./src/lib/**/Pipeline.dhall; do dhall --file "$f"; done
Xargs is cool, but for wildcarding, this is easier to read and maintain. If you are married to xargs, still prefer the following due to X-platform compat: echo ./src/jobs/**/Pipeline.dhall | xargs -n1 -I{} bash -c 'dhall --file "{}"'
Included here:
Tested by manually running the CI job:
Epic: #4762