You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The prometheus format specification has an optional timestamp after the value, but it's not possible to specify it with PrometheusMetric's render_sample currently. I was going to open a PR adding an Option<> parameter for it, but that'd be a breaking change. Is that fine, or should I make it as another function (e.g. render_sample_timestamp)?
I think a single function is better even if it will mean introducing a breaking change: the API should be as similar as possible to the specification (within reason OC)!
The prometheus format specification has an optional timestamp after the value, but it's not possible to specify it with
PrometheusMetric
'srender_sample
currently. I was going to open a PR adding anOption<>
parameter for it, but that'd be a breaking change. Is that fine, or should I make it as another function (e.g.render_sample_timestamp
)?The text was updated successfully, but these errors were encountered: