Add timestamp option to render_sample #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
This is a simple implementation where the parameter is
Option<i64>
. This leaves working with dates to the crate's users.From prometheus' documentation:
I think I could use https://docs.rs/chrono/0.4.11/chrono/struct.DateTime.html#method.timestamp_millis instead, so users can pass
chrono
'sDateTime
. The question is whether this is desirable, taking a hard dependency onchrono
. Another option would be anenum
with options of either aDateTime
or ani64
. (I will have to implement it for the exporter I'm writing anyway, so the question is just if it should be in this base crate, or not.) Let me know what you think @MindFlavor