Add clippy linting

.github/workflows/docker.yml

@@ -25,6 +25,9 @@ jobs:
     steps:
       - uses: actions/checkout@v2.3.4
 
+      - name: Lint
+        run: docker build --target lint
+
       - name: Build test image
         run: docker build --target test -t test-container .
 

Cargo.toml

@@ -31,3 +31,6 @@ http                     = "0.2"
 tokio                    = { version 	   = "1.0", features = ["macros", "rt"] }
 prometheus_exporter_base = { version       = "1.2", features = ["hyper_server"] }
 regex                    = "1.5.4"
+
+[dev-dependencies]
+clippy = "*"

Dockerfile

@@ -92,6 +92,12 @@ RUN rm -r \
 
 COPY . .
 
+FROM base AS lint
+ENTRYPOINT \
+    RUSTFLAGS="$(cat /tmp/rustflags)" \
+    CC="$(cat /tmp/musl)-gcc" \
+    cargo clippy --target "$(cat /tmp/rusttarget)"
+
 FROM base AS test
 ENTRYPOINT \
     RUSTFLAGS="$(cat /tmp/rustflags)" \

clippy.toml

@@ -0,0 +1 @@
+# see https://rust-lang.github.io/rust-clippy/master/index.html

src/main.rs

@@ -194,7 +194,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync>> {
     info!("using options: {:?}", options);
 
     let bind = matches.value_of("port").unwrap();
-    let bind = u16::from_str_radix(&bind, 10).expect("port must be a valid number");
+    let bind = (&bind).parse::<u16>().expect("port must be a valid number");
     let ip = matches.value_of("addr").unwrap().parse::<IpAddr>().unwrap();
     let addr = (ip, bind).into();
 

src/wireguard.rs

@@ -139,8 +139,7 @@ impl TryFrom<&str> for WireGuard {
             if let Some(endpoints) = wg.interfaces.get_mut(v[0]) {
                 endpoints.push(endpoint);
             } else {
-                let mut new_vec = Vec::new();
-                new_vec.push(endpoint);
+                let new_vec = vec![endpoint];
                 wg.interfaces.insert(v[0].to_owned(), new_vec);
             }
         }
@@ -212,10 +211,10 @@ impl WireGuard {
                     // store in attibutes their references. attributes_owned is onyl
                     // needed for separate ip+subnet
                     let mut attributes_owned: Vec<(String, String)> = Vec::new();
-                    let mut attributes: Vec<(&str, &str)> = Vec::new();
-
-                    attributes.push(("interface", interface));
-                    attributes.push(("public_key", &ep.public_key));
+                    let mut attributes: Vec<(&str, &str)> = vec![
+                        ("interface", interface),
+                        ("public_key", &ep.public_key),
+                    ];
 
                     if split_allowed_ips {
                         let v_ip_and_subnet: Vec<(&str, &str)> = ep