Implement scoped loggers from ModuleLoggers 🍰
#230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 95.01% 95.02%
=======================================
Files 97 97
Lines 3289 3295 +6
=======================================
+ Hits 3125 3131 +6
Misses 164 164
Continue to review full report at Codecov.
|
pakerwreah
approved these changes
Apr 7, 2021
On certain occasions, one needs to pass in a simple `Logger` instance but want log events forwarded to a larger logging infrastructure. If we're dealing with a `ModuleLogger` with multiple registered modules, one may want to derive a simpler `Logger` that sends all events under a single module to the upstream logger. To achieve that, `ModuleLogger` can now create scoped loggers via a new `scopedLogger(for:)` helper. ## Changes - Create `ModuleLogger.scopedLogger(for:)` helper. - Create new `Log.ForwardingLogger` private helper class to forward log events to an upstream (Module) logger.
p4checo
force-pushed
the
scoped-loggers-from-module-logger
branch
from
7ee0ea1
to
650e291
Compare
aclima93
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
On certain occasions, one needs to pass in a simple
Loggerinstance but want log events forwarded to a larger logging infrastructure.If we're dealing with a
ModuleLoggerwith multiple registered modules, one may want to derive a simplerLoggerthat sends all events under a single module to the upstream logger. To achieve that,ModuleLoggercan now create scoped loggers via a newscopedLogger(for:)helper.Description
Create
ModuleLogger.scopedLogger(for:)helper.Create new
Log.ForwardingLoggerprivate helper class to forward log events to an upstream (Module) logger.