Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM-488] Disable profiling support #450

Conversation

Deacon-McIntyre
Copy link
Contributor

@Deacon-McIntyre Deacon-McIntyre commented Apr 19, 2021

Raygun4Net will take over the APM sampling from the agent if Raygun4Net is installed into an app that has the APM profiler attached. We have removed this for .NET Core - see #449

Since it has been removed for the .NET Core part of Raygun4Net, we are opting to also remove it from the rest of Raygun4Net. This is for both consistency and maintainability.

Testing

  • Test that profiler sampling has affect before these changes
  • Build project(s) and check version has been updated
  • Reference locally built packages
  • Check that profiler sampling has no effect
  • Check that errors still come through

Copy link
Contributor

@mduncan26 mduncan26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 LGTM

@Deacon-McIntyre Deacon-McIntyre merged commit 7273f9d into master Apr 21, 2021
@Deacon-McIntyre Deacon-McIntyre deleted the dm/apm-488/disable-raygun4net-profiling-support-full-framework branch April 21, 2021 03:00
@darcythomas darcythomas restored the dm/apm-488/disable-raygun4net-profiling-support-full-framework branch August 3, 2023 01:05
@darcythomas darcythomas deleted the dm/apm-488/disable-raygun4net-profiling-support-full-framework branch August 3, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants