Fix missing cookie collection in ASP.NET Core provider #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and add standard error message if getting cookies fails
|
@QuantumNightmare any chance you could review this please? |
QuantumNightmare
approved these changes
Feb 28, 2022
|
This fix has been released in version 6.6.5 of the NuGet package now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for
request.HasFormContentTypewhen trying to get cookies from the request should not be there as the Form content has no bearing on a request containing cookies or not. It looks like this was copied over from the original implementation.I've also added a message to the cookies list if this method fails in line with the other methods in this class.