Windows: Replace FindFirstFile with GetFileAttributesExA and fix UNICODE builds #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly use the Ansi (A) API, otherwise builds with UNICODE defined will fail because the W-API expects utf16 strings.
|
So actually switching to explicit FindFirstFileA() / WIN32_FIND_DATAA is enough, yes? |
|
yes |
|
LGTM, the failures are due to changes travis-ci OSX changes with pkg-config. |
sezero
added a commit
that referenced
this pull request
Jun 3, 2017
|
Applied 858618 |
sezero
added a commit
that referenced
this pull request
Mar 6, 2018
|
Backported the fix to wildmidi-0.3: commit fc446be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced FindFirstFile with FileAttributesEx because the API is more suitable for quering information.
When WildMidi is compiled with UNICODE defined the WinApi functions expect UTF16 strings and FindFirstFile fails. I explictly use the A (ANSI) Api to mitigate this. (this matches the remaining functions like "open" a few lines later.
Only limitation is that wildmidi.cfg can't be in a path that has special characters outside of the current "local codepage" (see MSDN). Don't think it makes sense to make the API Unicode aware, who would put wildmidi in C:\日本\йцук\wildmidi.cfg.