Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bindings for Zig 0.11.x #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add bindings for Zig 0.11.x #242

wants to merge 2 commits into from

Conversation

deevus
Copy link

@deevus deevus commented May 30, 2023

Firstly, thanks for this project. I've been working on reverse engineering a MSDOS game and I was able to deobfuscate a bunch of HMP files, and then convert them to WAV files using wildmidi. 👍

I have been writing said project in Zig, so in doing that work I wrote a binding so that I could compile wildmidi into my program. In the spirit of OSS I'm contributing that work back here, if you want it. It has been tested on Windows, Linux and MacOS.

Let me know what else you would like me to do. E.g.:

  • Tests
  • GitHub Actions
  • Anything else?

For the Zig package manager to work, build.zig needs to be in the root of the project I think.

@sezero
Copy link
Contributor

sezero commented Apr 8, 2024

@psi29a : What do you think?

@sezero sezero requested a review from psi29a April 8, 2024 17:53
@psi29a
Copy link
Member

psi29a commented Apr 8, 2024

No idea, I mean... I don't think anyone here is willing to maintain Zig support, so I'm afraid that at some point, it will just break? This PR also does not have a .github action associated with it.

The assumption is that the c-api is enough for literally any language to import.

@sezero
Copy link
Contributor

sezero commented Apr 8, 2024

Leaving to your decision @psi29a

@deevus
Copy link
Author

deevus commented Apr 9, 2024

No idea, I mean... I don't think anyone here is willing to maintain Zig support, so I'm afraid that at some point, it will just break? This PR also does not have a .github action associated with it.

The assumption is that the c-api is enough for literally any language to import.

The PR description literally asks for feedback on whether it needs a GitHub action.

The PR is a year old at this point and went completely ignored until now. I wasn’t going to spend a bunch of time without even a nod from a maintainer that this is something they are interested in.

@sezero sezero added this to the 0.4.7 milestone Apr 11, 2024
@psi29a
Copy link
Member

psi29a commented Jul 19, 2024

Thanks @deevus ; I'm fine with this if you are @sezero
It doesn't touch anything else and just helps zig out.

@psi29a
Copy link
Member

psi29a commented Jul 19, 2024

@deevus if you would like to add github actions; feel free. tests if you'd like; make sure though that the actions/tests do not automatically the whole flow yet though please. :)

@deevus
Copy link
Author

deevus commented Jul 21, 2024

Ok I'll try to circle back round to update this again for 0.13.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants