-
Notifications
You must be signed in to change notification settings - Fork 3
Mcdoc command #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mcdoc command #18
Conversation
There'll probably be tweaks to both the querying and the rendering of the symbols in the future, but I'm happy with the state of this command now. I tried to follow the other cogs the best I could, but of course I'm not too experienced with this codebase, so please review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, but there's a few minor things I'd change.
Also, what should the config look like? I don't need the whole thing. Just the part for your extension. |
I am using the following config: {
"name": "commanderbot.ext.mcdoc",
"options": {
"symbols_url": "https://api.spyglassmc.com/vanilla-mcdoc/symbols",
"manifest_url": "https://piston-meta.mojang.com/mc/game/version_manifest_v2.json",
"emoji_prefix": "mcdoc_",
"icon_url": "https://avatars.githubusercontent.com/u/74945225?s=64"
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks better now. Thanks.
Uh oh!
There was an error while loading. Please reload this page.