Skip to content

Conversation

misode
Copy link
Contributor

@misode misode commented Jan 17, 2025

@misode misode marked this pull request as ready for review February 4, 2025 23:25
@misode misode requested a review from Ersatz77 as a code owner February 4, 2025 23:25
@misode
Copy link
Contributor Author

misode commented Feb 4, 2025

There'll probably be tweaks to both the querying and the rendering of the symbols in the future, but I'm happy with the state of this command now. I tried to follow the other cogs the best I could, but of course I'm not too experienced with this codebase, so please review :)

Copy link
Member

@Ersatz77 Ersatz77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but there's a few minor things I'd change.

@Ersatz77
Copy link
Member

Also, what should the config look like? I don't need the whole thing. Just the part for your extension.

@misode
Copy link
Contributor Author

misode commented Feb 18, 2025

I am using the following config:

{
  "name": "commanderbot.ext.mcdoc",
  "options": {
    "symbols_url": "https://api.spyglassmc.com/vanilla-mcdoc/symbols",
    "manifest_url": "https://piston-meta.mojang.com/mc/game/version_manifest_v2.json",
    "emoji_prefix": "mcdoc_",
    "icon_url": "https://avatars.githubusercontent.com/u/74945225?s=64"
  }
}

Copy link
Member

@Ersatz77 Ersatz77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better now. Thanks.

@Ersatz77 Ersatz77 merged commit ccd9fc9 into MinecraftCommands:main Feb 19, 2025
@misode misode deleted the mcdoc-command branch February 19, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants