Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Food/Hunger API #1758

Closed
wants to merge 2 commits into from
Closed

Added a Food/Hunger API #1758

wants to merge 2 commits into from

Conversation

Parker8283
Copy link
Contributor

This adds various events and utilities to help with the manipulation of Food and the Hunger system.

This code has been lifted from AppleCore, and documentation on all this can be found here: https://github.com/squeek502/AppleCore/wiki/Using-the-AppleCore-API under the first two bullet points in the Events section, and the Accessor section.

Also, tagging @squeek502, as this is his original code. I just took it out of his mod and lifted it into forge for all to have! (with permission of course :P)

@Geforce132
Copy link
Contributor

Cool, definitely would be useful in food/hunger-based mods.

@Parker8283
Copy link
Contributor Author

Anything missing for this to be pulled?

+ private int starveTimer;
+ //FORGE END

+ public FoodStats(EntityPlayer player)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default constructor is gone - someone might be using it

@Parker8283
Copy link
Contributor Author

Default constructor has been re-added and deprecated.

@cpw
Copy link
Contributor

cpw commented Apr 22, 2015

Can you verify compatibility with tterrags pr please?

@Parker8283
Copy link
Contributor Author

The only "conflict" I see between the two PRs is the fact that we both patch the ItemFood class. Also, his is for 1.7.10, but I assume it will be pulled up into 1.8. If you merge mine first, then merge his and bump to 1.8, there should be no issues. If you merge his first and pull up into 1.8, I will have to rerun genPatches so that the ItemFood patch lines up correctly.

@Parker8283
Copy link
Contributor Author

Anything else come up with this PR?

Parker8283 and others added 2 commits July 13, 2015 10:42
This adds various events and utilities to help with the manipulation of Food and the Hunger system.

This code has been lifted from AppleCore, and documentation on all this can be found here: https://github.com/squeek502/AppleCore/wiki/Using-the-AppleCore-API under the Events and Accessor section.
@Parker8283
Copy link
Contributor Author

I borked it! Thanks Git! grumbles

Will remake this PR with non-borkiness and inclusion of tterrag's breeding PR probably tomorrow, when I have more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants