Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16.5] Backport of DisplayTest feature #9809

Open
wants to merge 1 commit into
base: 1.16.x
Choose a base branch
from

Conversation

SrRapero720
Copy link
Contributor

I remade the PR, having gradle fix with feature addition

Backport of the DisplayTest feature added in #8656. Of course code was adapted to work on Java 8 and Pair system used on 1.16.5
Already tested and works fine

I modified AppleSkin mods.toml to use "MATCH_VERSION" and "IGNORE_SERVER_VERSION" and this is how it looks (ordered)
image

image

@SrRapero720 SrRapero720 changed the title Backport of DisplayTest feature [1.16.5] Backport of DisplayTest feature Nov 30, 2023
@SrRapero720
Copy link
Contributor Author

SrRapero720 commented Dec 2, 2023

i am not sure why but TC always takes checks from main branch, wich means old branches check was broken. specially below 1.18.2. building pass but other no implemented check fails by that, so nothing that i can fix on my side.

@PaintNinja PaintNinja added Feature This request implements a new feature. 1.16 labels Dec 2, 2023
@SrRapero720 SrRapero720 force-pushed the backports/16.5-District branch 2 times, most recently from 73b887c to fc4449c Compare December 19, 2023 04:12
@SrRapero720
Copy link
Contributor Author

rebased and fixed.

@SrRapero720
Copy link
Contributor Author

rebased again

@SrRapero720
Copy link
Contributor Author

For anyone who want want to know
this PR is blocked by missing 1.17.1 PR of this feature, which also is blocked by #9841

If anyone knows how to fix the damn 1.17.1 please summon me to add the patch quicky

@PaintNinja PaintNinja added the Queued Indicates that this PR is queued for merge in the next merge train. Depending on however triggers it label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.16 Feature This request implements a new feature. Queued Indicates that this PR is queued for merge in the next merge train. Depending on however triggers it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants