Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“All files should be saved in the './results' directory” should change along with settings #58

Closed
chazeon opened this issue Aug 3, 2018 · 5 comments
Labels
io Things related with input/output files of the package

Comments

@chazeon
Copy link
Member

chazeon commented Aug 3, 2018

Expected Behavior

The

All files should be saved in the './results' directory

line should change when the output directory is not results.

Actual Behavior

Writting:

All files should be saved in the './results' directory

in output even the output directory is not results anymore.

@chazeon chazeon changed the title “” “All files should be saved in the './results' directory should change along with settings” Aug 3, 2018
@chazeon chazeon changed the title “All files should be saved in the './results' directory should change along with settings” “All files should be saved in the './results' directory” should change along with settings Aug 3, 2018
@singularitti
Copy link
Member

singularitti commented Aug 3, 2018

I forget where this sentence lies?

All files should be saved in the './results' directory

@chazeon
Copy link
Member Author

chazeon commented Aug 3, 2018

qha/out.py Line 69.

@singularitti
Copy link
Member

singularitti commented Aug 3, 2018

What kind of behavior should we add? Should we use just a literal ``results`` (much simpler) or we use the runtime value of results (i.e., the value results in the settings.yaml)?

@chazeon
Copy link
Member Author

chazeon commented Aug 3, 2018

It depends on what you wish from it.

In my version, I had the output written to the stdout as well as the output file, it is therefore important to prompt the user which file relates to this section, therefore it should be written as a runtime value. (This makes changing NTV and other settings much faster.

However, in your older version, this line is just written to the output folder. This line has no meaning then because everything is already in this folder.

singularitti added a commit that referenced this issue Aug 4, 2018
singularitti added a commit that referenced this issue Aug 4, 2018
@singularitti
Copy link
Member

Resolved by removing this sentence.

@singularitti singularitti added the io Things related with input/output files of the package label Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io Things related with input/output files of the package
Projects
None yet
Development

No branches or pull requests

2 participants