Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue with failure to pick 9 random songs #13

Merged
merged 1 commit into from
Dec 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions client/script.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const clientId = 'd9827efb2c79463b92becb457a635a04';
const clientSecret = '6f2f0a36046f4f21980873a48c7bdab0';

// API dialogue functions
// --------------------- API dialogue functions ---------------------

function getRandomIntInclusive(min, max) {
const newMin = Math.ceil(min);
Expand Down Expand Up @@ -62,6 +62,7 @@ async function getTracks(token, tracksEndPoint, limit) {
return data;
}

// --------------------- Data handling functions ---------------------

async function initSongs(plalylistSg, genre, token){
// A function that gets us a the songs from a playlist
Expand Down Expand Up @@ -92,17 +93,18 @@ function songsToArray(songs){

// -------------------UI Handling-------------------

//Get random 10 items from an aray (to be replacedby betterselection item)
// Inject genres into the dropdown menu
function insertGenres(text, value, element) {
const html = `<option value="${value}">${text}</option>`;
element.insertAdjacentHTML('beforeend', html);
}

//Get random 10 items from an aray (to be replacedby betterselection item)
function getRandomTen(list) {
console.log('fired get 10 songs');
console.log('fired get 9 songs');
const range = [...Array(9).keys()];
const newArray = range.map(() => {
const index = getRandomIntInclusive(0, list.length);
const index = getRandomIntInclusive(0, list.length-1);
let picked = list[index];
return picked;
});
Expand All @@ -126,7 +128,7 @@ function injectHTML(list) {

//Inject images
function injectImages(list){
console.log('fired injectHTML');
console.log('fired injectImages');
const target = document.querySelector('#Imagebox');
target.innerHTML = '<h2>Songs are from these albums</h2><br>';

Expand Down Expand Up @@ -172,19 +174,22 @@ async function init(){
playlistEndpoint = `${playlist[0].href}/tracks`;
console.log(playlistEndpoint)

//Finally get the tracks
//Finally get the tracks and turn them into an array
const tracks = await initSongs(playlistEndpoint, genreName, token)
songArray = songsToArray(tracks)
document.getElementById("GeneratedContents").style.display = "none";
});


//
//Step 4: When user presses the submit button (broaden my horizons) we display 9 random songs out of those retrived.
//If the user keeps pressing submit he should get new songs from the same genre.
//If user changes genre the
submit.addEventListener('click', (e) => {
e.preventDefault();
const sample = getRandomTen(songArray)
console.log(sample);
injectHTML(sample);
injectImages(sample);
console.log(sample);
document.getElementById("GeneratedContents").style.display = "flex";

})
Expand Down
3 changes: 2 additions & 1 deletion client/styles.css
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
html {
background-color: rgb(130, 187, 231);
background-color: #1a1a1a;
font-size: 16px;
min-width: 300px;
overflow-x: hidden;
overflow-y: scroll;
color: #a7a7a7;

/* these are specific to different browsers */
-moz-osx-font-smoothing: grayscale;
Expand Down