This repository has been archived by the owner on May 30, 2022. It is now read-only.
Fix of erroneously accepted input when deserializing scalars #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should ensure, that incorrect input do not deserializing into object.
That could influence untagged enums because thy rely on deserialization
failures when selects right variant
failures (38):
trivial::struct_::cdata::byte_buf
trivial::struct_::cdata::char_
trivial::struct_::cdata::f32_
trivial::struct_::cdata::f64_
trivial::struct_::cdata::false_
trivial::struct_::cdata::i128_
trivial::struct_::cdata::i16_
trivial::struct_::cdata::i32_
trivial::struct_::cdata::i64_
trivial::struct_::cdata::i8_
trivial::struct_::cdata::isize_
trivial::struct_::cdata::string
trivial::struct_::cdata::true_
trivial::struct_::cdata::u128_
trivial::struct_::cdata::u16_
trivial::struct_::cdata::u32_
trivial::struct_::cdata::u64_
trivial::struct_::cdata::u8_
trivial::struct_::cdata::usize_
trivial::struct_::text::byte_buf
trivial::struct_::text::char_
trivial::struct_::text::f32_
trivial::struct_::text::f64_
trivial::struct_::text::false_
trivial::struct_::text::i128_
trivial::struct_::text::i16_
trivial::struct_::text::i32_
trivial::struct_::text::i64_
trivial::struct_::text::i8_
trivial::struct_::text::isize_
trivial::struct_::text::string
trivial::struct_::text::true_
trivial::struct_::text::u128_
trivial::struct_::text::u16_
trivial::struct_::text::u32_
trivial::struct_::text::u64_
trivial::struct_::text::u8_
trivial::struct_::text::usize_
…gative trivial tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following situation, when
is successfully deserialized from
when it shouldn't.