[BUG] Default to ActiveSupport::Notifications for pg and mysql2 #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
background: MiniProfiler#418 By default, rack mini profiler is expected to use active support notifications Before ====== Oracle is working as described, but pg and mysql are not. SqlPatches.sql_patches returns ["pg"] for postgres, patches postgres, and does not leverage ActiveSupport::Notifications After ===== Like oracle, postgres and mysql are double checking with patch_rails? to determine if the rails code should be patched. SqlPatches.sql_patches returns [] for postgres
kbrock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Per #418, Oracle defaults to using
ActiveSupport::Notifications. Settingpatch_rails?skips the notifications and uses rails.SqlPatches.sql_patchesignores that setting and always returns ["pg"] for postgres. So it always patches Postgres, and does not have a way to leverageActiveSupport::Notifications. The same holds with MySql.After
Like Oracle, Postgres and MySql are checking with
patch_rails?to determine if the rails code should be patched.SqlPatches.sql_patchesreturns[]for postgres and mysql.