Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.9 Support? #95

Closed
davidmezzetti opened this issue Oct 18, 2024 · 6 comments
Closed

Python 3.9 Support? #95

davidmezzetti opened this issue Oct 18, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@davidmezzetti
Copy link

Hello, first off nice project!

I was thinking of supporting this library in txtai but I see it requires Python 3.10+.

Is there something in the code that requires Python 3.10 or could this project work with Python 3.9? If so, could that requirement be opened up to >=3.9?

@Pringled
Copy link
Member

Hi @davidmezzetti, thanks for your interest in the project!

We can definitely add support for Python 3.9 if that makes it possible for you to support the library in txtai, sounds like a great fit. I've just created a PR to add support for this: #96. I think we can include this in the next release 👍 .

@davidmezzetti
Copy link
Author

Great. Just respond back when the release goes out and I'll add this as another vectorization method.

Should be an easy change on my side based on the example code I see. I appreciate it!

@Pringled
Copy link
Member

Great, will do, thanks!

@Pringled Pringled self-assigned this Oct 18, 2024
@stephantul stephantul added the enhancement New feature or request label Oct 20, 2024
@Pringled
Copy link
Member

Hi @davidmezzetti, we just released the latest model2vec version, including python3.9 support 🎉 . Full changelog is available here: https://github.com/MinishLab/model2vec/releases/tag/v0.3.0. The other big change is that inference now only depends on numpy, which might be nice for your usecase as well since the dependency is much more lightweight. If you do need distill functionality as well, you can install that with pip install model2vec[distill].

@davidmezzetti
Copy link
Author

Sounds great, I'll take a look and it will be in the next release of txtai!

@davidmezzetti
Copy link
Author

Just added this in with this neuml/txtai#801.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants