Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add python3.9 support #96

Merged
merged 9 commits into from
Oct 19, 2024
Merged

feat: Add python3.9 support #96

merged 9 commits into from
Oct 19, 2024

Conversation

Pringled
Copy link
Member

No description provided.

@Pringled Pringled requested a review from stephantul October 18, 2024 16:08
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model2vec/distill/tokenizer.py 56.00% 11 Missing ⚠️
Files with missing lines Coverage Δ
model2vec/distill/distillation.py 98.13% <100.00%> (+0.01%) ⬆️
model2vec/distill/inference.py 95.16% <100.00%> (+0.07%) ⬆️
model2vec/distill/utils.py 100.00% <100.00%> (ø)
model2vec/hf_utils.py 62.22% <100.00%> (+0.42%) ⬆️
model2vec/model.py 96.66% <100.00%> (ø)
tests/test_distillation.py 92.85% <100.00%> (+0.10%) ⬆️
tests/test_utils.py 100.00% <100.00%> (ø)
model2vec/distill/tokenizer.py 72.72% <56.00%> (+1.54%) ⬆️

@Pringled Pringled mentioned this pull request Oct 18, 2024
Copy link
Collaborator

@stephantul stephantul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Begrudging approve

@Pringled Pringled merged commit 0624c84 into main Oct 19, 2024
5 of 6 checks passed
@Pringled Pringled deleted the add-python-39-support branch October 19, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants