Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't rely on reported vocab size, log warning if inconsistent #109

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: don't rely on reported vocab size, log warning if inconsistent #109

merged 1 commit into from
Oct 23, 2024

Conversation

stephantul
Copy link
Collaborator

fixes #108

@stephantul stephantul requested a review from Pringled October 23, 2024 08:44
@stephantul stephantul mentioned this pull request Oct 23, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model2vec/distill/inference.py 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
model2vec/distill/inference.py 93.84% <75.00%> (-1.32%) ⬇️

@stephantul
Copy link
Collaborator Author

I think we can disregard the codecov warning. It's just a logging message, hard to simulate.

Pringled
Pringled approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM

@stephantul stephantul merged commit 5ed70a6 into main Oct 23, 2024
5 of 6 checks passed
@stephantul stephantul deleted the rely_on_vocab_directly branch October 23, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pringled Pringled Pringled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number of tokens (151646) does not match number of vectors (151643)
2 participants
@stephantul @Pringled