Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make encode_batch_fast optional #113

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

stephantul
Copy link
Collaborator

@stephantul stephantul commented Oct 25, 2024

If tokenizers < 0.20 is installed the code can still work, but we need a flag to know which function to call. I think this is worth supporting, because 0.20 is relatively new.

@stephantul stephantul requested a review from Pringled October 25, 2024 10:58
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tests/test_model.py 75.00% 3 Missing ⚠️
model2vec/model.py 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
tests/conftest.py 100.00% <100.00%> (ø)
model2vec/model.py 96.00% <83.33%> (-0.67%) ⬇️
tests/test_model.py 97.36% <75.00%> (-2.64%) ⬇️

@stephantul stephantul merged commit 97c2f5e into main Oct 25, 2024
5 of 6 checks passed
@stephantul stephantul deleted the make_encode_batch_fast_optional branch October 25, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants