Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated save_pretrained to save sentence-transformers compatible models #154

Merged
merged 7 commits into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions model2vec/hf_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,14 @@ def save_pretrained(
folder_path.mkdir(exist_ok=True, parents=True)
save_file({"embeddings": embeddings}, folder_path / "model.safetensors")
tokenizer.save(str(folder_path / "tokenizer.json"))
json.dump(config, open(folder_path / "config.json", "w"))
json.dump(config, open(folder_path / "config.json", "w"), indent=4)

# Create modules.json
modules = [{"idx": 0, "name": "0", "path": ".", "type": "sentence_transformers.models.StaticEmbedding"}]
if config.get("normalize"):
# If normalize=True, add sentence_transformers.models.Normalize
modules.append({"idx": 1, "name": "1", "path": "1_Normalize", "type": "sentence_transformers.models.Normalize"})
json.dump(modules, open(folder_path / "modules.json", "w"), indent=4)

logger.info(f"Saved model to {folder_path}")

Expand Down Expand Up @@ -75,7 +82,7 @@ def _create_model_card(
base_model=base_model_name,
license=license,
language=language,
tags=["embeddings", "static-embeddings"],
tags=["embeddings", "static-embeddings", "sentence-transformers"],
library_name="model2vec",
**kwargs,
)
Expand Down
1 change: 1 addition & 0 deletions tests/test_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ def test_save_pretrained(
assert (save_path / "model.safetensors").exists()
assert (save_path / "tokenizer.json").exists()
assert (save_path / "config.json").exists()
assert (save_path / "modules.json").exists()


def test_load_pretrained(
Expand Down
30 changes: 15 additions & 15 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading