Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with modernbert tokenizer, add token pattern to _distill #158

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: issue with modernbert tokenizer, add token pattern to _distill #158

merged 1 commit into from
Jan 23, 2025

Conversation

stephantul
Copy link
Member

No description provided.

@stephantul stephantul requested a review from Pringled January 23, 2025 08:33
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
model2vec/distill/distillation.py 95.23% <100.00%> (+0.07%) ⬆️

@stephantul stephantul merged commit 6b18e20 into main Jan 23, 2025
6 checks passed
@stephantul stephantul deleted the fix-modernbert branch January 23, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pringled Pringled Pringled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephantul @Pringled