Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sentence transformers dependency #35

Merged
merged 4 commits into from
Sep 26, 2024
Merged

remove sentence transformers dependency #35

merged 4 commits into from
Sep 26, 2024

Conversation

stephantul
Copy link
Collaborator

No description provided.

@tomaarsen tomaarsen mentioned this pull request Sep 26, 2024
Closed
7 tasks
Pringled
Pringled approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@Pringled Pringled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor typos

model2vec/distill/inference.py Outdated Show resolved Hide resolved
model2vec/distill/inference.py Outdated Show resolved Hide resolved
stephantul and others added 2 commits September 26, 2024 11:34
@stephantul @Pringled
Update model2vec/distill/inference.py
9573a8f 
Co-authored-by: Thomas van Dongen <thomas123@live.nl>
@stephantul @Pringled
Update model2vec/distill/inference.py
e27eb8d 
Co-authored-by: Thomas van Dongen <thomas123@live.nl>
@stephantul stephantul merged commit 7949845 into main Sep 26, 2024
@stephantul stephantul deleted the remove_sentence_transformers_dep branch September 26, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pringled Pringled Pringled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephantul @Pringled