Fix distill model bos and eos token #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bos_token_id
andeos_token_id
appear to be reversed in thecreate_output_embeddings_from_model_name
function withinmodel2vec/distill/inference.py
.When I testing with following code
before the fix
bos_token_id
is102
andeos_token_id
is101
but for BERT tokenizer the correctbos_token_id
andeos_token_id
should be