[Grammar] Types #44
Merged
[Grammar] Types #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopperm
approved these changes
May 4, 2022
| @@ -481,7 +496,7 @@ class Visualizer { | |||
| } | |||
|
|
|||
| private def dispatch VisualNode genNode(StringLiteral node) { | |||
| return makeImmediateLiteral(node.value) | |||
| return makeImmediateLiteral(node.value); | |||
There was a problem hiding this comment.
Fine for now, but a point for #10 -- Consistent use of semicolons in Xtend code.
Comment on lines
-215
to
+223
| def dispatch Iterable<Declarator> directDeclarations(CompositeTypeSpecifier spec) { | ||
| if (spec.declarations.size > 0) | ||
| spec.declarations.directDeclarations | ||
| else { | ||
| val specifier = spec.eContainer.findCompositeType([ | ||
| CompositeTypeSpecifier d|d.name!==null?d.name==spec.name:false | ||
| ]) | ||
| specifier===null?#[]:specifier.declarations.directDeclarations | ||
| } | ||
| def dispatch Iterable<Declarator> directDeclarations(UserTypeSpecifier spec) { | ||
| switch(spec) { | ||
| case StructTypeSpecifier: return (spec as StructTypeSpecifier).target.members.flatMap[it.declarators] | ||
| case UnionTypeSpecifier: return (spec as UnionTypeSpecifier).target.members.flatMap[it.declarators] | ||
| case EnumTypeSpecifier: return #[] | ||
| } |
There was a problem hiding this comment.
Much appreciated code simplification here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements suggestions 10, 11, and 12 from #39 and fixes #23.
Structure Changes
architectural_statesection{Struct|Union|Enum}TypeSpecifierpointing to{Struct|Union|Enum}TypeDeclarationexternon a function with body, or omit the body of a non-extern functionName Changes
CoreDefcontributingTypeCoreDefprovidedInstructionSetsFunctionDefinitiontypeFunctionDefinitionreturnTypeExpressionInitializerexprExpressionInitializervalueBitFieldleftBitFieldstartIndexBitFieldrightBitFieldendIndexFieldEncodingField