Use mintbasev2.near instead of mintbase2.near
#519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tifrel
requested review from
GAllen98,
bh2smith,
marcelokunze,
SurgeCode,
sainthiago,
microchipgnu,
nategeier,
Jxnis and
rubenmarcus
as code owners
sainthiago
approved these changes
Jul 5, 2024
bh2smith
reviewed
Jul 8, 2024
| @@ -18,7 +18,7 @@ Example usage: | |||
| import { dynamicNftMetadata } from '@mintbase-js/data' | |||
|
|
|||
| const props = { | |||
| contractAddress: 'dynamic.mintbase2.near', | |||
| contractAddress: 'dynamic.mintbasev2.near', | |||
There was a problem hiding this comment.
This appears so many times it could easily be a global constant. Then future changes wouldn't touch so much code.
There was a problem hiding this comment.
It already is a global constant, but used only sporadically. The changes also resulted from the fact that the name was arbitrarly used in places and I just replaced it in all the project even where it didn't have anything to do with the factory.
bh2smith
approved these changes
Jul 8, 2024
sainthiago
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.