Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually enable x-scrolling when citations overflow. #178

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

efocht
Copy link
Contributor

@efocht efocht commented Aug 4, 2023

Only 3 and a half citations are displayed in the chat history. When there are more, there is no scroll bar to access them. Tiny fix to enable a horizontal scroll bar in this case. Obviously this was intended in the original code but the no-scroll was wrong.

@timothycarambat
Copy link
Member

.no-scroll does not prevent overflow-x-scroll it just stops the scroll bar from showing. If you were to place your cursor over the items and scroll left right (like on a trackpad) it would work as intended. I think the issue may be just hiding the scroll bar on Windows since then the control is missing for them.

@timothycarambat
Copy link
Member

.no-scroll::-webkit-scrollbar {
  display: none !important;
}

/* Hide scrollbar for IE, Edge and Firefox */
#chat-history,
#chat-container,
.no-scroll {
  -ms-overflow-style: none !important;
  /* IE and Edge */
  scrollbar-width: none !important;
  /* Firefox */
}

@efocht
Copy link
Contributor Author

efocht commented Aug 4, 2023

I'm sorry, my explanation is probably wrong. The impact is the same :-(

I am using Firefox under Linux and am not able to scroll to the right to access the citations that are hidden. I use a keyboard and a mouse, no trackpad. I recon this would work on a laptop with trackpad scrolling with 2 fingers. Or a tablet. But not on a desktop.

@timothycarambat
Copy link
Member

Out of curiosity - if you go to the area where it shows the 3 1/2 citations and hold Shift and then scroll - it does scroll, right?

Not saying that's the solution but want to be sure scrolling works at all for non-x-axis scrolling devices

@timothycarambat timothycarambat merged commit 4ac5e55 into Mintplex-Labs:master Aug 7, 2023
@timothycarambat
Copy link
Member

Also, merged this! Ping me in Discord if you are in there and get a contributor role!

bbaaxx added a commit to bbaaxx/anything-llm-chained that referenced this pull request Aug 7, 2023
Actually enable x-scrolling when citations overflow. (Mintplex-Labs#178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants