Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milvus bug fix #2183

Merged

Conversation

shatfield4
Copy link
Collaborator

@shatfield4 shatfield4 commented Aug 27, 2024

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #2159

What is in this change?

  • Wrap addDocumentToNamespace function in try catch to catch any errors from Milvus to prevent crashing of the backend server

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 linked an issue Aug 27, 2024 that may be closed by this pull request
@timothycarambat timothycarambat merged commit a58f271 into master Sep 9, 2024
@timothycarambat timothycarambat deleted the 2159-bug-crash-when-try-embed-a-document-using-milvus branch September 9, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Crash when try embed a document using milvus
2 participants