Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utility functions unit test #2

Merged
merged 9 commits into from
Apr 29, 2019
Merged

Utility functions unit test #2

merged 9 commits into from
Apr 29, 2019

Conversation

farismosman
Copy link
Contributor

@farismosman farismosman commented Apr 28, 2019 •
edited
Loading

  1. Unit testing utility functions in the module named utils.
  2. Include a minor bug fix for the function overall_uplift_gain_ where col_treatment and col_outcome might not default to 'Treatment' and 'Outcome' respectively.
  3. Imports missing numpy module.
  4. The functions score_df and conf_mat_df were not unit-tested. I will have to think of a good test.

@farismosman farismosman marked this pull request as ready for review April 28, 2019 19:30
@Minyus Minyus self-assigned this Apr 29, 2019
@Minyus Minyus added bug Something isn't working enhancement New feature or request labels Apr 29, 2019
@Minyus Minyus merged commit c1fae27 into Minyus:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Minyus Minyus

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farismosman @Minyus