Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-404: Fix pre-commit hook preparing commit message #3

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

SophieCurinier
Copy link
Contributor

@SophieCurinier SophieCurinier commented Jul 29, 2024

DEVOPS-404 - in GEOPY packages and templates: fix pre-commit hook preparing commit message

@SophieCurinier SophieCurinier requested a review from sebhmg July 29, 2024 13:32
@github-actions github-actions bot changed the title [DEVOPS-404] Fix pre-commit hook preparing commit message DEVOPS-404: Fix pre-commit hook preparing commit message Jul 29, 2024
Copy link
Contributor

@sebhmg sebhmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with tests! Awesome. Thanks @SophieCurinier !

See one non-blocking suggestion for reusing BangPattern in regex string.
Up to you to commit as-is or to bring it back in development

mirageoscience/hooks/git_message_hook.py Show resolved Hide resolved
@SophieCurinier SophieCurinier merged commit 979eb16 into main Jul 29, 2024
2 checks passed
@SophieCurinier SophieCurinier deleted the DEVOPS-404 branch July 29, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants