Skip to content

Commit

Permalink
Set a default network plugin now that we're on 1.24
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Barry committed Aug 2, 2022
1 parent 97c83e7 commit 910dcea
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
# Skip runtime should support execSync with timeout because docker doesn't
# support it.
# Skip apparmor test as we don't enable apparmor yet in this CI job, or selinux
sudo /usr/local/bin/critest -runtime-endpoint=unix:///var/run/cri-dockerd.sock -ginkgo.skip="runtime should support apparmor|runtime should support reopening container log|runtime should support execSync with timeout|runtime should support selinux"
sudo /usr/local/bin/critest -runtime-endpoint=unix:///var/run/cri-dockerd.sock -ginkgo.skip="runtime should support apparmor|runtime should support reopening container log|runtime should support execSync with timeout|runtime should support selinux|runtime should support propagation.*"
- name: Run benchmark
working-directory: src/sigs.k8s.io/cri-tools
Expand Down
16 changes: 12 additions & 4 deletions cmd/cri/options/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,20 +103,28 @@ var (
// NewContainerRuntimeOptions will create a new ContainerRuntimeOptions with
// default values.
func NewContainerRuntimeOptions() *config.ContainerRuntimeOptions {
dockerEndpoint := ""
var dockerEndpoint, cniBinDir, cniConfDir, networkPluginName string

if runtime.GOOS != "windows" {
dockerEndpoint = "unix:///var/run/docker.sock"
cniBinDir = "/opt/cni/bin"
cniConfDir = "/etc/cni/net.d"
networkPluginName = "kubenet"
} else {
cniBinDir = "C:\\k\\cni\\bin"
cniConfDir = "C:\\k\\cni\\config"
networkPluginName = "cni"
}

runtimeOptions := &config.ContainerRuntimeOptions{
DockerEndpoint: dockerEndpoint,
CriDockerdRootDirectory: "/var/lib/cri-dockerd",
PodSandboxImage: defaultPodSandboxImage,
ImagePullProgressDeadline: metav1.Duration{Duration: 1 * time.Minute},
NetworkPluginName: "cni",
NetworkPluginName: networkPluginName,

CNIBinDir: "/opt/cni/bin",
CNIConfDir: "/etc/cni/net.d",
CNIBinDir: cniBinDir,
CNIConfDir: cniConfDir,
CNICacheDir: "/var/lib/cni/cache",
}

Expand Down

0 comments on commit 910dcea

Please sign in to comment.