Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Makefiles #254

Open
nwneisen opened this issue Oct 11, 2023 · 0 comments
Open

Consolidate Makefiles #254

nwneisen opened this issue Oct 11, 2023 · 0 comments
Labels
build good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nwneisen
Copy link
Collaborator

nwneisen commented Oct 11, 2023

Expected Behavior

A Makefile exists in the root of the project that imports Makefile values and targets from other mk files.

We should try to move the project towards being organized using the standard go project layout. This would have us moving our imported mk files to the build/ directory along with the packaging directory.

Suggested project reorganization:

build/
  packaging/*
  common.mk -> Move high level Makefile vars here
  packaging.mk -> Current packaging/Makefile
packaging/
Makefile -> Import the build/*.mk files

Since we are currently placing our build artifacts in the build directory, we should instead output them to the bin directory as is common practice with many projects. We should also eliminate any duplicate build artifacts.

Actual Behavior

We currently have Makefiles in multiple locations throughout the project with duplicated targets and variables. This is not the end of the world but it there are now multiple different ways to build different artifacts for the project.

@nwneisen nwneisen added good first issue Good for newcomers help wanted Extra attention is needed build labels Oct 11, 2023
zhangwt-cn added a commit to zhangwt-cn/cri-dockerd that referenced this issue Oct 12, 2023
- Move packaging -> build/
- Modified creating-a-release.md common.mk path
- Cancel .gitignore /build

Close Mirantis#254
zhangwt-cn added a commit to zhangwt-cn/cri-dockerd that referenced this issue Oct 13, 2023
- Move packaging -> build/
- Modified creating-a-release.md common.mk path
- Cancel .gitignore /build

Close Mirantis#254
zhangwt-cn added a commit to zhangwt-cn/cri-dockerd that referenced this issue Oct 13, 2023
- Move packaging -> build/
- Modified creating-a-release.md common.mk path
- Cancel .gitignore /build

Close Mirantis#254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant