Allow Templates deletion by the controller only #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eromanova
force-pushed
the
template-validation
branch
2 times, most recently
from
176cb64
to
f27b9ce
Compare
eromanova
force-pushed
the
template-validation
branch
3 times, most recently
from
104b5ec
to
8fa5584
Compare
The admission controller will block the removal of any Template managed by HMC or from the system namespace if the request is not made by the HMC controller.
eromanova
force-pushed
the
template-validation
branch
from
8fa5584
to
5d46cee
Compare
Kshatrix
requested changes
Sep 27, 2024
| if serviceAccountIsEqual(req, os.Getenv(ServiceAccountEnvName)) { | ||
| return true, nil | ||
| } | ||
| // Cluster-scoped ProviderTemplates and Templates from the system namespace are not allowed to be deleted |
There was a problem hiding this comment.
It should be ok to delete templates from the system namespace as long as they are not in-use in any templatechains
| if err != nil { | ||
| return false, err | ||
| } | ||
| if v.InjectUserInfo != nil { |
There was a problem hiding this comment.
is this one only for unit tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The admission controller will block the removal of any Template managed by HMC or from the system namespace if the request is not triggered by the HMC controller.
Closes #329