Validate available upgrades for managed clusters #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerospiel
requested changes
Sep 25, 2024
eromanova
force-pushed
the
clusters-upgrade-validation
branch
4 times, most recently
from
1fcaa14
to
d5d6aeb
Compare
eromanova
force-pushed
the
clusters-upgrade-validation
branch
from
d5d6aeb
to
9c8a9e3
Compare
zerospiel
reviewed
Sep 26, 2024
eromanova
force-pushed
the
clusters-upgrade-validation
branch
from
9c8a9e3
to
d4ff7ee
Compare
Kshatrix
requested changes
Sep 27, 2024
| @@ -84,6 +97,15 @@ func (v *ManagedClusterValidator) ValidateUpdate(ctx context.Context, _ runtime. | |||
| if err != nil { | |||
| return nil, fmt.Errorf("%s: %v", errInvalidManagedCluster, err) | |||
| } | |||
| if !newManagedCluster.Spec.DryRun && templateutil.IsManagedByHMC(template) { | |||
There was a problem hiding this comment.
We wanted to have a list of available upgrades in the managedcluster status and only check that the requested template is in the list in admission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admission webhook will validate the
ManagedCluster'sspec.template update and in case theManagedClusteris not in dry run mode and theClusterTemplateis managed by HMC it will verify if the newClusterTemplateis in the list of available upgrades in theClusterTemplateChain.Closes #372
Closes #244