Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCM/CSI credentials propagation #405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CCM/CSI credentials propagation #405

wants to merge 1 commit into from

Conversation

a13x5
Copy link
Contributor

@a13x5 a13x5 commented Sep 27, 2024 •
edited
Loading

Resolves #324
Resolves #325

Notes:

  1. This must be merged after Add Credential CR and controller #342. When Add Credential CR and controller #342 merged Add Credential CR and controller will be removed from this PR. Now it's cherry-picked here for clarity.
  2. Azure CCM Helm chart has issue (Helm chart: cloud config secret flag passed incorrectly kubernetes-sigs/cloud-provider-azure#7188) with controller flags, so it isn't working with secret. CSI works fine. Please don't merge this PR before it's fixed!
  3. I'm not sure if we should fail on unsupported infrastructure provider. Now the ManagedCluster will not transition to Ready when some other (than AWS, Azure or vSphere) infrastructure provider will be used. Probably this isn't right.

@a13x5 a13x5 self-assigned this Sep 27, 2024
@a13x5 a13x5 force-pushed the ccm-credentials-delivery branch 5 times, most recently from d299e98 to 8565164 Compare October 4, 2024 00:19
@a13x5 a13x5 force-pushed the ccm-credentials-delivery branch 3 times, most recently from ad8ad8c to dd0cc7f Compare October 7, 2024 14:14
@a13x5 a13x5 marked this pull request as ready for review October 7, 2024 14:22
@a13x5 a13x5 requested a review from zerospiel October 7, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kshatrix Kshatrix Awaiting requested review from Kshatrix Kshatrix is a code owner

@eromanova eromanova Awaiting requested review from eromanova eromanova is a code owner

@zerospiel zerospiel Awaiting requested review from zerospiel

At least 1 approving review is required to merge this pull request.

Assignees

@a13x5 a13x5

Labels
None yet
Projects
Project 2A
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust cluster templates according to new CCM/CSI secret propagation CCM/CSI credentials propagation
1 participant
@a13x5