Unify k8s api endpoints #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| }, | ||
| NegotiatedSerializer: api.Codecs, | ||
| } | ||
| thirdPartyResourceConfigInit(&c) |
There was a problem hiding this comment.
this and below duplicates the same in dependencies.go. Could it be refactored somehow?
nebril
force-pushed
the
unify-k8s-api-endpoints
branch
from
ed74703
to
31a313e
Compare
|
LGTM. It's a bit weird that the client contains deps and resdefs, both referring to the same restclient, but i can not see better way,at least right now. |
|
This should be merged after kubernetes/kubernetes#28414 is released |
nebril
force-pushed
the
unify-k8s-api-endpoints
branch
from
31a313e
to
c90007c
Compare
|
The fix will be released in 1.4 afaik. |
|
kubernetes/kubernetes#28414 is merged now so it will be included in 1.4 release. |
|
@nebril Can we add there a check for a k8s version inside AC? Then it would crash with useful message. |
nebril
force-pushed
the
unify-k8s-api-endpoints
branch
from
c90007c
to
9da8581
Compare
nebril
force-pushed
the
unify-k8s-api-endpoints
branch
from
c6070e4
to
453dbdb
Compare
|
@pigmej done |
nebril
force-pushed
the
unify-k8s-api-endpoints
branch
from
453dbdb
to
78566a4
Compare
nebril
force-pushed
the
unify-k8s-api-endpoints
branch
from
78566a4
to
a525646
Compare
|
Reviewed 21 of 21 files at r1, 1 of 1 files at r2. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25
This change is