Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOP-409] [BOP-1114] Cloud Providers #107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tppolkow
Copy link
Collaborator

@tppolkow tppolkow commented Oct 1, 2024

No description provided.

@tppolkow tppolkow requested a review from a team as a code owner October 1, 2024 20:21
weight: 6
---

Enabling CloudProvider allows your MKE cluster to integrate with cloud provider addons. Currently, only AWS is supported as an MKE managed cloud provider addon.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enabling CloudProvider allows your MKE cluster to integrate with cloud provider addons. Currently, only AWS is supported as an MKE managed cloud provider addon.
`cloud-provider` is a Kubernetes component that you use to define the shared interfaces that are implemented by Kubernetes cloud service providers. By enabling `cloud-provider`, you allow your MKE 4 cluster to integrate with cloud service provider add-ons.
{{< callout type="note" >}}
AWS is currently the only managed cloud service provider add-on supported by MKE 4. To use a different cloud service provider, you must set MKE 4 to run with "external" cloud provider and install the desired cloud provider.
{{< /callout >}}

Copy link
Collaborator Author

@tppolkow tppolkow Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KoryKessel-Mirantis The first sentence you added doesn't make sense here, I believe you are defining the Kubernetes cloud provider, but this is an interface designed to be used by developers developing their own cloud provider addons ( hence the shared interfaces that are implemented by Kubernetes cloud service providers ). It doesn't really make sense here as here they are enabling the "implemented interface" i.e the AWS cloud provider (which implements the generic Kubernetes defined interface)

---

Enabling CloudProvider allows your MKE cluster to integrate with cloud provider addons. Currently, only AWS is supported as an MKE managed cloud provider addon.
To use other cloud providers, you must set MKE to run with "external" cloud provider and install the cloud provider yourself.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this line, as it has been wrapped up into the preceding Note callout.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

To use other cloud providers, you must set MKE to run with "external" cloud provider and install the cloud provider yourself.

## Pre-requisites
Cloud Providers may have additional requirements. Please refer to the specific cloud provider documentation for more information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Cloud Providers may have additional requirements. Please refer to the specific cloud provider documentation for more information.
Refer to the documentation for your chosen cloud service provider to learn of any proprietary requirements.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Enabling CloudProvider allows your MKE cluster to integrate with cloud provider addons. Currently, only AWS is supported as an MKE managed cloud provider addon.
To use other cloud providers, you must set MKE to run with "external" cloud provider and install the cloud provider yourself.

## Pre-requisites
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Pre-requisites
## Prerequisites

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tppolkow tppolkow force-pushed the BOP-1114-add-cloudprovider-docs branch from 0b915f6 to 9496fc3 Compare October 7, 2024 19:14
@KoryKessel-Mirantis KoryKessel-Mirantis changed the title Add docs for cloud provider [BOP-409] [BOP-1114] Cloud Providers Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants