Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calico support #411

Merged
merged 9 commits into from
Oct 3, 2017
Merged

Calico support #411

merged 9 commits into from
Oct 3, 2017

Conversation

ivan4th
Copy link
Contributor

@ivan4th ivan4th commented Sep 12, 2017 •
edited
Loading

Fixes #224

TODO:

  • basic PoC support for Calico with manual IP address assignment
  • add check for CNI plugin type and only use the workaround for Calico
  • implement proper dummy gateway IP address allocation (likely will have to use another daemonset or at least a pod)
  • calculate netmask that covers both pod IP and the gateway
  • add descriptive comments in the code why the workaround is needed and how it works
    (should be both in code and architecture docs)
  • make sure e2e tests pass for Calico
  • update the documentation
  • fix ubuntu vm

This change is Reviewable

@ivan4th ivan4th force-pushed the ivan4th/calico branch 6 times, most recently from 83a4433 to d79b96b Compare September 29, 2017 09:19
@ivan4th ivan4th changed the title [WiP] Calico support Calico support Sep 29, 2017
@pigmej
Copy link
Contributor

pigmej commented Oct 2, 2017

:lgtm:

Tested using: #443

export CNI_PLUGIN=calico
VIRTLET_DEMO_BRANCH=ivan4th/calico deploy/demo.sh

Review status: 0 of 9 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@lukaszo
Copy link
Contributor

lukaszo commented Oct 3, 2017

:lgtm:

Reviewed 2 of 9 files at r1.
Review status: 2 of 9 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@lukaszo
Copy link
Contributor

lukaszo commented Oct 3, 2017

Reviewed 7 of 9 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

@ivan4th ivan4th merged commit a0f2a07 into master Oct 3, 2017
@ivan4th ivan4th deleted the ivan4th/calico branch October 3, 2017 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Calico
3 participants
@ivan4th @pigmej @lukaszo