Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass original MTU to VM using dhcp #547

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Pass original MTU to VM using dhcp #547

merged 2 commits into from
Jan 10, 2018

Conversation

jellonek
Copy link
Contributor

@jellonek jellonek commented Jan 3, 2018 •
edited by pigmej
Loading

This change is Reviewable

@pigmej
Copy link
Contributor

pigmej commented Jan 8, 2018

Can we documment that it's only in DCHP part?

Review status: 0 of 6 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@jellonek
Copy link
Contributor Author

jellonek commented Jan 8, 2018

Done.

Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@pigmej
Copy link
Contributor

pigmej commented Jan 8, 2018

:lgtm:

Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Jan 10, 2018

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion.

docs/networking.md, line 109 at r1 (raw file):

**NOTE:** At the moment Virtlet supports passing `MTU` to VM for network
interfaces configured by CNI plugins only through it's builtin `DHCP` server.

At the moment Virtlet can only pass MTU values configured for the network interfaces by CNI plugins to VMs via its built-in DHCP server.

Comments from Reviewable

@jellonek
Copy link
Contributor Author

Review status: 0 of 7 files reviewed at latest revision, 1 unresolved discussion.

docs/networking.md, line 109 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

At the moment Virtlet can only pass MTU values configured for the network interfaces by CNI plugins to VMs via its built-in DHCP server.

Done.

Comments from Reviewable

@pigmej
Copy link
Contributor

pigmej commented Jan 10, 2018

Reviewed 6 of 7 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

@pigmej
Copy link
Contributor

pigmej commented Jan 10, 2018

:lgtm:

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Jan 10, 2018

:lgtm:

Review status: 2 of 7 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@ivan4th
Copy link
Contributor

ivan4th commented Jan 10, 2018

:lgtm:

Review status: 2 of 7 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@pigmej
Copy link
Contributor

pigmej commented Jan 10, 2018

:lgtm:

Reviewed 5 of 5 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@pigmej pigmej merged commit d04d591 into master Jan 10, 2018
@pigmej pigmej deleted the jell/mtu branch January 10, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jellonek @pigmej @ivan4th