ConfigDrive support + fix on dns search

[jellonek]

TODO:

• update integration test for ConfigDrive
• update docs

---

This change is 

[jellonek]

Ok. It's ready to review.

[ivan4th]

Review status: 0 of 23 files reviewed at latest revision, 4 unresolved discussions.

---

docs/cloud-init-data-generation.md, line 20 at r1 (raw file):

ConfigDrive. Which one should be used is controlled by annotation
`VirtletCloudInitImageType`. It accepts as values `nocloud`, `configdrive` and
defaults to `nocloud` when annotation is not set.

Virtlet supports two types of Cloud-init ISO9660-based datasources, NoCloud and
ConfigDrive. The user may choose an appropriate one using
VirtletCloudInitImageType annotation, which can have either nocloud or configdrive as its value.
When there's no VirtletCloudInitImageType annotation, Virtlet defaults to nocloud.

---

docs/cloud-init-data-generation.md, line 160 at r1 (raw file):

In case of Config Drive this JSON has duplicated `instance-id` as `uuid` and
`local-hostname` as `hostname`.

In case of ConfigDrive, this JSON has instance-id repeated as uuid and local-hostname repeated as hostname.

---

pkg/libvirttools/cloudinit_test.go, line 99 at r1 (raw file):

		expectedNetworkConfig map[string]interface{}
		expectedUserDataStr   string
	}{

Is it possible to add a configdrive test case(s) here ? It shouldn't be hard

---

pkg/libvirttools/cloudinit_test.go, line 364 at r1 (raw file):

		},
		{
			name: "pod with network config",

These test cases need to be implemented for "configdrive", too

---

Comments from Reviewable

[jellonek]

Review status: 0 of 23 files reviewed at latest revision, 4 unresolved discussions.

---

docs/cloud-init-data-generation.md, line 20 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Virtlet supports two types of Cloud-init ISO9660-based datasources, NoCloud and
ConfigDrive. The user may choose an appropriate one using
VirtletCloudInitImageType annotation, which can have either nocloud or configdrive as its value.
When there's no VirtletCloudInitImageType annotation, Virtlet defaults to nocloud.

Done.

---

docs/cloud-init-data-generation.md, line 160 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

In case of ConfigDrive, this JSON has instance-id repeated as uuid and local-hostname repeated as hostname.

Done.

---

pkg/libvirttools/cloudinit_test.go, line 99 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Is it possible to add a configdrive test case(s) here ? It shouldn't be hard

Done.

---

pkg/libvirttools/cloudinit_test.go, line 364 at r1 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

These test cases need to be implemented for "configdrive", too

Done.

---

Comments from Reviewable

[ivan4th]

---

Review status: 0 of 23 files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[pigmej]

---

Reviewed 22 of 24 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[jellonek]

Rebased on top of master. Please wait for tests and rereview.

[ivan4th]

---

Review status: 21 of 23 files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[pigmej]

---

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable