e2e tests for virtlet pod restart

[lukaszo]

It's build on top of #480

This change is 

[jellonek]

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks failed.

---

tests/e2e/restart_virtlet_test.go, line 38 at r2 (raw file):

	BeforeAll(func() {
		includeDisruptive()

Such thing in BeforeAll() will not work. It needs to be added to test case (to It()).
That's why now in test logs you have first case skipped, but second executed.

---

Comments from Reviewable

[lukaszo]

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

tests/e2e/restart_virtlet_test.go, line 38 at r2 (raw file):

Previously, jellonek (Piotr Skamruk) wrote…

Such thing in BeforeAll() will not work. It needs to be added to test case (to It()).
That's why now in test logs you have first case skipped, but second executed.

Ah, thx. I was searching for it in a docs

---

Comments from Reviewable

[jellonek]

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

tests/e2e/restart_virtlet_test.go, line 38 at r2 (raw file):

Previously, lukaszo (Łukasz Oleś) wrote…

Ah, thx. I was searching for it in a docs

https://godoc.org/github.com/Mirantis/virtlet/tests/e2e/ginkgo-ext ;)

---

Comments from Reviewable

[ivan4th]

Reviewed 1 of 2 files at r3.
Review status: 1 of 4 files reviewed at latest revision, 1 unresolved discussion.

---

deploy/virtlet-ds.yaml, line 196 at r3 (raw file):

            - /bin/sh
            - -c
            - socat - UNIX:/run/virtlet.sock </dev/null

Maybe we should add a similar probe for the libvirt container?

---

tests/e2e/restart_virtlet_test.go, line 2 at r3 (raw file):

/*
Copyright 2017 Mirantis

2018

---

tests/e2e/restart_virtlet_test.go, line 69 at r3 (raw file):

	}, 3*60)

	It("Should contain logs from attach session", func() {

"Virtlet restart Should contain logs from another session" doesn't sound good, maybe "Should keep logs from another session"?

---

Comments from Reviewable

[lukaszo]

Review status: 1 of 4 files reviewed at latest revision, 4 unresolved discussions.

---

deploy/virtlet-ds.yaml, line 196 at r3 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

Maybe we should add a similar probe for the libvirt container?

Done.

---

tests/e2e/restart_virtlet_test.go, line 2 at r3 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

2018

Done.

---

tests/e2e/restart_virtlet_test.go, line 69 at r3 (raw file):

Previously, ivan4th (Ivan Shvedunov) wrote…

"Virtlet restart Should contain logs from another session" doesn't sound good, maybe "Should keep logs from another session"?

Done.

---

Comments from Reviewable

[ivan4th]

Reviewed 5 of 5 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[ivan4th]

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[jellonek]

---

Reviewed 5 of 5 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable